Hey @eren.can any update to the commits here?
Niklas Fix (709b488f) at 01 Feb 17:22
fix(module): fixed meine duelle not showing after loading
... and 7 more commits
Niklas Fix (565e13b0) at 01 Feb 17:18
fix(module): fixed meine duelle not showing after loading
... and 12 more commits
I think you have to be a bit careful with your commits. E.g. your last commit
0b682287 - feat(module): added circular loader for dashboard lists is named feat(module), yet, it changes files basically everywhere. Please be more granular with your commits during development. Also, I think, you need to do an interactive rebase to squash some of your commits into single ones (e.g. the ones with the same name). Otherwiese, after merging, the other developers will get a lot of issues when rebasing. Another option would be to group the commits into:
For the future, please keep an eye on just adding code to the MR that actually belongs to the feature or the bugfix you are working on and don't mixup multiple topics in one MR ;)
see above, my fault, please revert...
That's okay ^^
You can have a look into the modules/duel/state files. As you see, there are multiple states, one for each request basically. That's what I was trying to recommend to you, too :) Let me know, if you need more help :)
ok, you need to check on allAvatars
again however
something like this (note that I changed the callback parameter name of resultAll.when to result, otherwise you get the behavior that the parameter is set with itself, which is not what you want):
var allAvatars = <Avatar>[];
var unlockedAvatars = <Avatar>[];
resultAll.when(
success: (result) {
allAvatars = result;
},
failure: (failure) {
state = const AvatarFetchForModalState.error('Error');
return;
},
);
resultUnlocked.when(
success: (result) {
unlockedAvatars = result;
},
failure: (failure) {
state = const AvatarFetchForModalState.error('Error');
return;
},
);
state = AvatarFetchForModalState.success(allAvatars, unlockedAvatars);
better :)
Alight
No need to forward the original error ;)
You can
see above. My fault... please revert to watch
Not sure if I missed something, but did you add an indicator somewhere?
Ah you added it in the abstract component, cool
Remove
These changes do not belong to the MR. If you want to add them and that's okay for all other developers, too, then create a new MR. But they have nothing to do with the feature you're implementing at the moment.
These changes do not belong to the MR. If you want to add them and that's okay for all other developers, too, then create a new MR. But they have nothing to do with the feature you're implementing at the moment.
These changes do not belong to the MR. If you want to add them and that's okay for all other developers, too, then create a new MR. But they have nothing to do with the feature you're implementing at the moment.
These changes do not belong to the MR. If you want to add them and that's okay for all other developers, too, then create a new MR. But they have nothing to do with the feature you're implementing at the moment.
These changes do not belong to the MR. If you want to add them and that's okay for all other developers, too, then create a new MR. But they have nothing to do with the feature you're implementing at the moment.
Ah nice.
I'm going to implement a circular progress indicator while the user auth is loading Not sure if that's necessary. Once you're logged in, the user should be authorized anyway. If we want to catch the loading / unauthorized state properly, we would need to do it globaly somehow and not a new logic in every widget that's accessing the auth-state. SO i think this is out-of-scope of this MR anyway.
Now I have to apologize, I just added a comment on Discord. It s actually not recommended to use read
in the Widget's `build' method. Sorry for confusion! You need to revert the change...